Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb run_id params through the UI #906

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Plumb run_id params through the UI #906

merged 1 commit into from
Dec 12, 2018

Conversation

lukebjerring
Copy link
Contributor

Description

Support loading /results with a run_id param (or a few), by plumbing the params through to the component.

Review Information

  • Load /results?run_id=[A run ID]&run_id=[Another run ID]
  • Be amazed

This is a precursor to a better fix for #889

@lukebjerring lukebjerring requested a review from Hexcles December 12, 2018 17:57
@lukebjerring lukebjerring mentioned this pull request Dec 12, 2018
Merged
@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://run-ids-dot-wptdashboard-staging.appspot.com

Hexcles
Hexcles approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukebjerring
Copy link
Contributor Author

Verified via https://run-ids-dot-wptdashboard-staging.appspot.com/results/?run_id=6341547230494720

@lukebjerring lukebjerring merged commit b950844 into master Dec 12, 2018
@lukebjerring lukebjerring deleted the run-ids branch December 12, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexcles Hexcles Hexcles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukebjerring @wpt-pr-bot @Hexcles