Add field for a SHA, with autocomplete #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging instance deployed by Travis CI! |
added 2 commits
October 24, 2018 22:01
added 2 commits
October 25, 2018 10:13
Hexcles
approved these changes
Oct 30, 2018
| let same = true; | ||
| for (let i = 0; i < shas.length && same; i++) { | ||
| if (i >= curr.length || shas[i] !== curr[i]) { | ||
| same = false; |
There was a problem hiding this comment.
A few suggestions about this loop:
- Why do we need to check
i >= curr.length? The whole loop only runs ifcurrandshashave the same length. - We can simply break here, instead of checking
sameevery time. - Once 1 & 2 are done, then we can simplify the 3-clause for into a for...of (which, unlike for...in, is guaranteed to iterate in order).
There was a problem hiding this comment.
Updated to match the versions autocomplete logic I simplified earlier today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting towards #687 (for the all-the-same SHA case)
Adds a WPT flag for
queryBuilderSHAwhich supports fetching the/api/shasendpoint for the current query, and populating the autocomplete of the SHA field using possibilities.Review Information
Visit
/flags, enable bothqueryBuilderandqueryBuilderSHA, type stuff.