Fix two query API bugs #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `gzip` reader/writers do not close their delegates 1. Wrap in new `compositeReadWriteCloser` 1. `*memcacheWriteCloser` ptr type (not `memcacheWriteCloser` value type) should be `io.WriteCloser`
|
Staging instance deployed by Travis CI! |
lukebjerring
approved these changes
Sep 6, 2018
Hexcles
reviewed
Sep 6, 2018
| @@ -97,17 +135,17 @@ func (mc memcacheReadWritable) NewReadCloser(key string) (io.ReadCloser, error) | |||
| } | |||
|
|
|||
| func (mc memcacheReadWritable) NewWriteCloser(key string) (io.WriteCloser, error) { | |||
There was a problem hiding this comment.
@mdittmer I know you've merged the PR but still want to share a thought on this:
The fact that changing the return value doesn't change the function signature reminds me of a Go convention that we didn't follow here: take interfaces as arguments, and return concrete types. In this example, we should return *memcacheWriteCloser. Explicitness in return values benefits the callers (and callers don't have to care - they can always use := or even assign the return value to an interface type), while the polymorphism in arguments makes the function more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gzipreader/writers do not close their delegatescompositeReadWriteCloser*memcacheWriteCloserptr type (notmemcacheWriteCloservalue type) should beio.WriteCloser