-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go 1.19 [Pt.2] #3070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI checks won't pass until webplatformtests/wpt.fyi:latest is updated. |
jcscottiii
added a commit
that referenced
this pull request
Dec 8, 2022
ran go get -u ./... Depends on: #3070
webplatformtests/wpt.fyi:latest was just updated. CI checks pass. This is good to go now |
DanielRyanSmith
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
KyleJu
approved these changes
Dec 8, 2022
jcscottiii
added a commit
that referenced
this pull request
Dec 8, 2022
ran go get -u ./... Depends on: #3070
jcscottiii
added a commit
that referenced
this pull request
Dec 8, 2022
* Update all the go dependencies ran go get -u ./... Depends on: #3070 * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps 3&4 from https://github.com/web-platform-tests/wpt.fyi/blob/main/docs/upgrading-go.md
Depends on #3067
This PR is part 2 of 2.