Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify details around review approvals before merging #199

Merged
merged 4 commits into from
Oct 1, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,21 @@ Cases where the RFC process need *not* be used:
* Risks
- The proposal is discussed by the community and it is assumed that the
proposal will change in accordance with that discussion.
- In the case of no substantive disagreement the RFC is considered accepted
after 1 week. If any participant requests it, the comment period is extended
to 2 weeks.
- At least one review approval is required to merge a PR. For changes that
may impact downstream WPT consumers more approvals should be sought, or at
least a clear acknowledgement from those consumers that this change can be
accommodated in their workflows.
past marked this conversation as resolved.
Show resolved Hide resolved
- Anyone is welcome to add the PR to the monthly
[WPT infra meeting](https://github.com/web-platform-tests/wpt-notes) to
have a dsicsussion about it. To add an RFC to the agenda, tag the PR with the
`agenda+` label.
- If reviewers or downstream consumers are not responsive after at least two
past marked this conversation as resolved.
Show resolved Hide resolved
weeks, the PR should be added to the monthly
[WPT infra meeting](https://github.com/web-platform-tests/wpt-notes) to
ensure it gets discussed.
- After review approval(s) and in the case of no substantive disagreement, the
RFC is considered accepted 1 week after the first approval. If any participant
requests it, the comment period is extended to 2 weeks.
past marked this conversation as resolved.
Show resolved Hide resolved
- If substantive disagreement remains, then the issue is escalated to the
[core team](https://github.com/orgs/web-platform-tests/teams/wpt-core-team/)
for a decision:
Expand Down