Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

support non localhost #40

Merged
merged 3 commits into from
Nov 21, 2017
Merged

support non localhost #40

merged 3 commits into from
Nov 21, 2017

Conversation

mattl
Copy link
Contributor

@mattl mattl commented Nov 7, 2017

In adding support for an external database hosts to the pulls.wpt site --
bocoup/infrastructure-web-platform#8 -- I need to extend the code to support non-localhost databases. This is a work-in-progress PR for that.


This change is Reviewable

@mattl mattl changed the title WIP: support non localhost support non localhost Nov 13, 2017
@mattl
Copy link
Contributor Author

mattl commented Nov 13, 2017

This has been running for many days on the pulls.wpt website. Assigning to @lukebjerring to help me get this merged.

@mattl mattl requested a review from lukebjerring November 13, 2017 18:59
.gitignore Outdated
@@ -99,3 +99,14 @@ config.txt

# Mac Finder
.DS_Store

# mattl uses Emacs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foolip uses Emacs too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, when I once tried to add *~ to the .gitignore of a project where the maintainer wasn't an Emacs user, it was not so well received and I was pointed to something like https://stackoverflow.com/a/7335487

I actually haven't set that up myself, but that is a way to not being annoyed by this kind of thing in new repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the correct answer is to set up a global gitignore file (there are default paths, you don't actually need to set any config path) containing OS and editor-specific ignores (and GitHub's gitignores repo includes standard ones for both).

@rwaldron
Copy link

Travis is failing because there is no .travis.yml, so it can be safely ignored for now.

@foolip
Copy link
Member

foolip commented Nov 21, 2017

I went to check the "Build only if .travis.yml is present" bit to make that problem go away.

@mattl mattl requested a review from rwaldron November 21, 2017 20:00
Copy link
Contributor Author

@mattl mattl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this file.

Copy link

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -97,5 +97,3 @@ config.txt
# Vagrant
.vagrant

# Mac Finder
.DS_Store

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This didn't belong here anyway :)

@rwaldron rwaldron merged commit 77a7cd6 into master Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants