Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form-Associated Custom Elements #203

Closed
Westbrook opened this issue Oct 12, 2022 · 8 comments
Closed

Form-Associated Custom Elements #203

Westbrook opened this issue Oct 12, 2022 · 8 comments
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal

Comments

@Westbrook
Copy link

Description

The form-associated custom elements APIs enable custom elements to participate in form submission and validation lifecycles.

This agreed upon spec is not fully delivered cross browser. Following the Web Platform Test link below, you will find the it is currently missing in Safari and suffers from a number of failures in Firefox.

Rationale

  • Enable custom elements to participate in form submission by adding a value to the FormData object, adding to the HTMLFormElement.prototype.elements object and in other submission formats.
  • Enables custom elements to participate in the form validation lifecycle by providing APIs similar to and building on top of the constraint validation APIs.

Specification

https://html.spec.whatwg.org/multipage/custom-elements.html#form-associated-custom-elements

Tests

https://github.com/web-platform-tests/wpt/tree/master/custom-elements/form-associated

@Westbrook Westbrook added the focus-area-proposal Focus Area Proposal label Oct 12, 2022
@foolip foolip moved this to Proposed in Interop 2023 Oct 12, 2022
@foolip foolip mentioned this issue Oct 12, 2022
@karlcow
Copy link

karlcow commented Oct 13, 2022

WebKit Bug

@josepharhar
Copy link

Here is some potentially additional description and rationale: https://w3c.github.io/webcomponents-cg/#form-associated-custom-elements

In addition to the custom-elements/form-associated directory in WPT, I believe that these tests also test form-associated custom elements:

@hsinyi
Copy link

hsinyi commented Nov 1, 2022

Based on the discussion with @jcsteh , we'd like to exclude the ones tested with ARIA idref attributes under https://wpt.fyi/results/custom-elements/form-associated/ElementInternals-accessibility.html

We are interested in keeping the non-idref part in the scope. However, there appear to be open spec issues for this part :
w3c/aria#1110
w3c/aria#1239

How likely is it that we can get consensus on the spec issues before the start of the Interop period?

@josepharhar
Copy link

I am happy to drop ElementInternals-accessibility.html or separate subtests of it if needed. I don't have context on those aria issues and I don't know how likely they are to be resolved before the start of the interop period.

@domenic
Copy link
Member

domenic commented Nov 8, 2022

Based on the discussion with @jcsteh , we'd like to exclude the ones tested with ARIA idref attributes under https://wpt.fyi/results/custom-elements/form-associated/ElementInternals-accessibility.html

Honestly this test seems to be in the wrong directory. It is not related to form-associated custom elements and should be in the parent directory.

@josepharhar
Copy link

Honestly this test seems to be in the wrong directory. It is not related to form-associated custom elements and should be in the parent directory.

Sound good to me, I created a PR to do it: web-platform-tests/wpt#36875

domenic pushed a commit to web-platform-tests/wpt that referenced this issue Nov 9, 2022
@foolip
Copy link
Member

foolip commented Nov 11, 2022

In the MDN short survey on APIs & JavaScript, "Web Components (custom elements, Shadow DOM, etc.)" was the most popular choice by a fairly wide margin, selected by ~39% of survey takers.

Web Components was split into many granular proposals, and the survey results don't tell us which aspects web developers want the most, but it's fair to say that something about Web Components is important. (I'm posting this comment on each of the split proposals.)

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 12, 2022
…of form-associated, a=testonly

Automatic update from web-platform-tests
Move ElementInternals-accessibility out of form-associated

This change was suggested here:
web-platform-tests/interop#203 (comment)

--

wpt-commits: 871938e34bcd5c11b92c0c20afb7c44128150332
wpt-pr: 36875
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 14, 2022
…of form-associated, a=testonly

Automatic update from web-platform-tests
Move ElementInternals-accessibility out of form-associated

This change was suggested here:
web-platform-tests/interop#203 (comment)

--

wpt-commits: 871938e34bcd5c11b92c0c20afb7c44128150332
wpt-pr: 36875
jgraham added a commit to web-platform-tests/wpt-metadata that referenced this issue Jan 17, 2023
See
web-platform-tests/interop#203 (comment)
web-platform-tests/interop#230 (comment)

Since the concerns in those issues were not addressed and there was
agreement to drop the tests in that case, I'm removing them from the
Interop set.
github-actions bot pushed a commit to web-platform-tests/wpt-metadata that referenced this issue Jan 17, 2023
See
web-platform-tests/interop#203 (comment)
web-platform-tests/interop#230 (comment)

Since the concerns in those issues were not addressed and there was
agreement to drop the tests in that case, I'm removing them from the
Interop set.
@nairnandu nairnandu added the accepted An accepted proposal label Feb 1, 2023
@nairnandu
Copy link
Contributor

Thank you for proposing Form-Associated Custom Elements for inclusion in Interop 2023.

We are pleased to let you know that this proposal was accepted as part of the Web Components focus area. You can follow the progress of this Focus Area on the Interop 2023 dashboard.

For an overview of our process, see the proposal selection summary. Thank you for contributing to Interop 2023!

Posted on behalf of the Interop team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal
Projects
No open projects
Status: Proposed
Development

No branches or pull requests

7 participants