Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css-scroll-snap/capturing-snap-positions.html #108

Closed
nt1m opened this issue Aug 13, 2022 · 10 comments
Closed

Remove css-scroll-snap/capturing-snap-positions.html #108

nt1m opened this issue Aug 13, 2022 · 10 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nt1m
Copy link
Member

nt1m commented Aug 13, 2022

** Test List **

  • css-scroll-snap/capturing-snap-positions.html

** Rationale **

@nmoucht investigated this, and found this is testing an "at-risk" feature of css-scroll-snap, see: w3c/csswg-drafts#4496

It's also worth noting this is failing in all 3 browsers.

@nt1m nt1m added the test-change-proposal Proposal to add or remove tests for an interop area label Aug 13, 2022
@foolip
Copy link
Member

foolip commented Aug 18, 2022

@flackr WDYT?

@nt1m
Copy link
Member Author

nt1m commented Aug 18, 2022

@emilio @theres-waldo @jgraham What do you think?

@theres-waldo
Copy link

theres-waldo commented Aug 18, 2022

cc @hiikezoe

@hiikezoe
Copy link

Thanks Botond for CCing me. Honestly I wasn't aware of w3c/csswg-drafts#4496 at all. In fact the situation in Gecko is pretty much same as what Majido mentioned in w3c/csswg-drafts#4496 (comment) . We don't care non scroll containers at all as of now, Handling non scroll containers wouldn't be too hard in Gecko, but I am not a big fan of it. I wonder web developers can intuitively understand the scroll-snap-type property behavior for such cases.

Anyway though I don't quite understand what the expected outcomes of the interop 2022 tasks are, dropping the test sounds reasonable to me.

@nt1m
Copy link
Member Author

nt1m commented Aug 30, 2022

@flackr Hi! Have you had a chance to look at this?

@flackr
Copy link

flackr commented Aug 30, 2022

This is a tricky one. It's at risk and not implemented by any browsers so on track for removal, but it is still in the spec and in w3c/csswg-drafts#4496 there were good arguments for this feature making scroll snap more ergonomic, being relatively straigtforward to implement, and the plan is to revisit its removal after the rest of the spec is implemented. I do not think it makes sense to remove the test so long as it is still "planned" - perhaps rename it to be a tentative test instead to reflect its current at risk position?

@nt1m
Copy link
Member Author

nt1m commented Aug 30, 2022

@flackr Thanks for taking a look! If it's a tentative test, I think we should at least exclude it from Interop 2022 (not necessarily remove the test from WPT).

@nt1m
Copy link
Member Author

nt1m commented Sep 2, 2022

@foolip It seems like there's general agreement to remove it from Interop, should I (or you) move forward with the change?

@foolip
Copy link
Member

foolip commented Sep 15, 2022

@nt1m sorry for the delay, I'll remove the label now.

@foolip
Copy link
Member

foolip commented Sep 15, 2022

Done in web-platform-tests/wpt-metadata#3007.

@foolip foolip closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants