Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for SVG-AAM role mapping #69

Closed
5 tasks done
Tracked by #3
cookiecrook opened this issue Oct 17, 2023 · 5 comments · Fixed by web-platform-tests/wpt#43196
Closed
5 tasks done
Tracked by #3

Write tests for SVG-AAM role mapping #69

cookiecrook opened this issue Oct 17, 2023 · 5 comments · Fixed by web-platform-tests/wpt#43196
Assignees
Labels

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Oct 17, 2023

@cookiecrook cookiecrook changed the title Precursors and tests for SVG-AAM role mapping Write tests for SVG-AAM role mapping Oct 17, 2023
@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Nov 15, 2023

Trying to list the currently testable rules here for a v1 set of WPT tests from:

This is my shorthand version, so it may be imprecise, but good enough as a starting point to write the tests.

  1. the following should be treated as generics by default: shape elements (circle, ellipse, line, path, polygon, polyline, rect), use, g, image, mesh, text formatting elements (textPath, tspan), and foreignObject
  2. All elements (including those above) should be included IF the element is both rendered (many element types won't ever be rendered), and one of the following is true:
    • it has a non-empty direct child[sic] title element or desc element
    • it has a non-empty aria-label or aria-roledescription attr.
    • valid aria-labelledby or aria-describedby
    • valid integer tabindex
    • non-generic role (not generic/none/presentation/etc)
    • other criteria from Core-AAM Including Elements in the Accessibility Tree
    • question/todo: find where text elements (not just formatters) fit into these rules, or file a spec issue
  3. Unless… it should not be included, b/c one of the following exclusion rules applies (and so it's not exposed)
    • It's generic/none/presentation/etc (expose the descendant contents but not it)
    • aria-hidden="true" (other hidden types are accounted for with the "rendered" criteria above)
    • ancestor element is Children Presentational: True (such as a button)
  4. Unless… it's focusable or becomes focused, then it is exposed.

@cookiecrook
Copy link
Collaborator Author

Pretty confident this last 2% of the interop investigation score is taking up more than 2% of the effort.

@cookiecrook cookiecrook self-assigned this Nov 15, 2023
@cookiecrook
Copy link
Collaborator Author

Also testable, the title element and xlink:title attr fallbacks in the SVG-AAM name comp variations (noting the caveats in w3c/svg-aam#31)

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Nov 16, 2023

Draft WPT PR #43196 is up. A lot is blocked. Some areas could be filled out a little bit more with additional exhaustive test cases, but I think the current version is a good size to value ratio. Any larger, and I'm going to have trouble getting reviewers to commit their time.

All the blocked stuff is tracked in #80. I will look at this Issue/PR again tomorrow to make sure I didn't miss anything obvious, then ask for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant