Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bypass abandoned syntax in four AOM crashtests #56

Closed
cookiecrook opened this issue Aug 21, 2023 · 1 comment · Fixed by web-platform-tests/wpt#41576
Closed

bypass abandoned syntax in four AOM crashtests #56

cookiecrook opened this issue Aug 21, 2023 · 1 comment · Fixed by web-platform-tests/wpt#41576
Assignees
@cookiecrook

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Aug 21, 2023 •
edited
Loading

./accessibility/crashtests/aom-in-destroyed-iframe.html and three other AOM tests are testing abandoned API that will not be implemented in any other browser.

I think we should either:

  • update so that they pass in any browser that does not implement the abandoned getComputedAccessibleNode, or
  • remove the tests entirely.
@cookiecrook cookiecrook self-assigned this Aug 22, 2023
@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Aug 22, 2023 •
edited
Loading

At first I thought this may have been a real crash, but it's failing as a ReferenceError to an undefined API. The log is just misleading... Even if I add a conditional around it, it fails as a TIMEOUT. Will see if I can find another solution or just remove these.

[Update: WPT Docs FTW!]

@cookiecrook cookiecrook reopened this Aug 22, 2023
@cookiecrook cookiecrook changed the title Remove test for abandoned API in AOM crashtest: aom-in-destroyed-iframe.html Remove test for abandoned API in four AOM crashtests Aug 22, 2023
cookiecrook added a commit to cookiecrook/wpt that referenced this issue Aug 22, 2023
@cookiecrook
bypass bogus AOM crashtests that assume abaondoned API will be added.
dc8d5d4 
Closes web-platform-tests/interop-accessibility#56
@cookiecrook cookiecrook mentioned this issue Aug 22, 2023
Merged
@cookiecrook cookiecrook changed the title Remove test for abandoned API in four AOM crashtests bypass abandoned syntax in four AOM crashtests Aug 22, 2023
cookiecrook added a commit to web-platform-tests/wpt that referenced this issue Aug 23, 2023
@cookiecrook
bypass bogus AOM crashtests that assume abaondoned API will be added. (…
b685181 
…#41576)

Closes web-platform-tests/interop-accessibility#56
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 13, 2023
@cookiecrook @moz-wptsync-bot
Bug 1849663 [wpt PR 41576] - bypass bogus AOM crashtests that assume …
e3e79ad 
…abandoned syntax will be added., a=testonly

Automatic update from web-platform-tests
bypass bogus AOM crashtests that assume abaondoned API will be added. (#41576)

Closes web-platform-tests/interop-accessibility#56
--

wpt-commits: b6851815cc6c4a69dc7f64f593fa93a538230ec8
wpt-pr: 41576
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Sep 14, 2023
@cookiecrook @moz-wptsync-bot
Bug 1849663 [wpt PR 41576] - bypass bogus AOM crashtests that assume …
1f62972 
…abandoned syntax will be added., a=testonly

Automatic update from web-platform-tests
bypass bogus AOM crashtests that assume abaondoned API will be added. (#41576)

Closes web-platform-tests/interop-accessibility#56
--

wpt-commits: b6851815cc6c4a69dc7f64f593fa93a538230ec8
wpt-pr: 41576
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
@cookiecrook @Lightning00Blade
bypass bogus AOM crashtests that assume abaondoned API will be added. (…
ce8111b 
…web-platform-tests#41576)

Closes web-platform-tests/interop-accessibility#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cookiecrook cookiecrook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bypass bogus AOM crashtests that assume abandoned syntax will be added. cookiecrook/wpt
1 participant
@cookiecrook