Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccName: tests/todos in accname/name/comp_host_language_label #33

Closed
Tracked by #3
cookiecrook opened this issue Apr 27, 2023 · 5 comments · Fixed by web-platform-tests/wpt#40913
Closed
Tracked by #3
Assignees

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Apr 27, 2023

AccName: Remaining tests/todos in accname/name/comp_host_language_label.html

https://w3c.github.io/accname/#comp_host_language_label

@cookiecrook cookiecrook changed the title AccName: Remaining tests/todos in accname/name/comp_host_language_label.html AccName: tests/todos in accname/name/comp_host_language_label Apr 27, 2023
@cookiecrook cookiecrook self-assigned this May 23, 2023
@cookiecrook
Copy link
Collaborator Author

Currently working on a PR for:

  • label for/id with text, checkbox, etc.
  • label encapsulation with text, checkbox, etc.
  • img
    • no alt, empty alt, alt=""
    • same variants w/img in picture element
  • image map area alt
  • input[type=image][alt] (what happens if for/id label is also added?)
  • table caption
  • summary details?
  • svg title? (possibly test in svg-aam?)
  • are there math or ruby host lang labels?
  • did I miss others?

@scottaohara @jnurthen thoughts?

@cookiecrook
Copy link
Collaborator Author

@scottaohara mentioned placeholder="foo" on HTML text fields

@scottaohara
Copy link

title attribute for various elements (is that going to be accounted here?)

fieldset > legend - as per mention of table > caption

re: summary/details - there is presently no naming relation between these. just naming of the summary element via different methods.

@cookiecrook
Copy link
Collaborator Author

title attribute for various elements (is that going to be accounted here?)

Not here. title is a general enough pattern to be tested in another accname test. If HTML-AAM increases the priority of title over one of the other earlier steps in the name computation, then that's specific enough to be tested in HTML-AAM… Along with a cross-reference here so that no one duplicates the work...

re: summary/details - there is presently no naming relation between these. just naming of the summary element via different methods.

Okay. I assumed the label was anything inside summary but not inside details…

<summary data-expectedlabel="summary details label" data-testname="html: summary > details" class="ex">
  summary details label
  <details>hidden content</details>
</summary>

Will remove from PR.

@scottaohara
Copy link

@cookiecrook ah, i see why you'd think that now. That markup is a bit inside out from how those elements are meant to be setup.

<details>
  <summary>summary details label</summary>
  hidden content here
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants