Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are /accessibility/crashtests tests valuable for Interop 2024? #100

Closed
foolip opened this issue Jan 19, 2024 · 7 comments
Closed

Are /accessibility/crashtests tests valuable for Interop 2024? #100

foolip opened this issue Jan 19, 2024 · 7 comments
Assignees

Comments

@foolip
Copy link
Member

foolip commented Jan 19, 2024

While reviewing some of the accessibility-related proposals for Interop 2024, the Interop Team has looked at which existing tests in WPT might be appropriate to include from the ones already labeled accessibility:

https://wpt.fyi/results/?label=master&label=experimental&aligned&q=label%3Aaccessibility

There are 50 crashtests here that we're not sure about:

https://wpt.fyi/results/accessibility/crashtests?label=experimental&label=master&aligned

The only failure there is due to web-platform-tests/wpt#13183 (comment). Given that there aren't any actionable failures here, is it worthwhile to include them?

@cookiecrook can you advise?

@cookiecrook
Copy link
Collaborator

cookiecrook commented Feb 3, 2024

There's one new test (with timeout failures across the board) since the time you filed this issue, but I don't have a strong argument for or against keeping the crashtests dir in Interop 2024. @aleventhal wrote the majority of those and may have an opinion.

@aleventhal
Copy link

aleventhal commented Feb 5, 2024 via email

@jgraham
Copy link
Contributor

jgraham commented Feb 5, 2024

The test you linked with the tinmouts doesn't seem to be one of the B accessibility crash tests (although it's pretty weird that it's timing out across all browsers).

It's timing out because currently crashtests don't support testdriver (see web-platform-tests/wpt#13183 which is mostly about reftests; crashtests are probably slightly easier, but the story is similar).

For now you'd need to rewrite that as a testharness test.

@cookiecrook
Copy link
Collaborator

cookiecrook commented Feb 6, 2024

@jgraham @boazsender I've tracked that change in #106. Thanks.

@foolip Seems like the interop-2024-accessibility label has been removed from the crashtests dir, so can this issue be closed? If so, please do. Thanks!

@cookiecrook
Copy link
Collaborator

Confirmed removal of the crashtests. Closing.

@aleventhal
Copy link

I didn't see a reason posited for their removal. They aren't useful? I assume these are useful if anyone is implementing aria-owns.

@chrishtr
Copy link

chrishtr commented Mar 5, 2024

I didn't see a reason posited for their removal. They aren't useful? I assume these are useful if anyone is implementing aria-owns.

Just to clarify, this is about removing them from Interop 2024, not deleting the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants