Skip to content

Commit

Permalink
Add more keys to PiP and use compute_from (#2050)
Browse files Browse the repository at this point in the history
  • Loading branch information
Elchi3 authored Oct 28, 2024
1 parent 247d925 commit 350974e
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 12 deletions.
19 changes: 7 additions & 12 deletions features/picture-in-picture.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@ name: Picture-in-picture (video)
description: The picture-in-picture API allow websites to create a floating, always-on-top video window. Also known as PiP or pop-out video.
spec: https://w3c.github.io/picture-in-picture/
caniuse: picture-in-picture
# TODO: Align the initial Chrome version these sources:
# https://github.com/mdn/browser-compat-data/pull/7603 (Chrome 69)
# https://caniuse.com/picture-in-picture (Chrome 70)
# https://chromestatus.com/feature/5729206566649856 (Chrome 71)
#
# For now we will match BCD, Chrome 69.
status:
compute_from: api.Document.pictureInPictureElement
compat_features:
- api.Document.exitPictureInPicture
- api.Document.pictureInPictureElement
Expand All @@ -22,9 +18,8 @@ compat_features:
- api.PictureInPictureWindow.width
- api.ShadowRoot.pictureInPictureElement
- html.elements.video.disablepictureinpicture
# Later additions:
# - api.PictureInPictureEvent
# - api.PictureInPictureEvent.PictureInPictureEvent
# - api.PictureInPictureEvent.pictureInPictureWindow
# - css.selectors.picture-in-picture
# - http.headers.Permissions-Policy.picture-in-picture
- api.PictureInPictureEvent
- api.PictureInPictureEvent.PictureInPictureEvent
- api.PictureInPictureEvent.pictureInPictureWindow
- css.selectors.picture-in-picture
- http.headers.Permissions-Policy.picture-in-picture
33 changes: 33 additions & 0 deletions features/picture-in-picture.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ status:
safari: "13.1"
safari_ios: "13.4"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: false
# support:
# chrome: "69"
# chrome_android: "105"
# edge: "79"
# safari: "13.1"
# safari_ios: "13.4"
- api.Document.exitPictureInPicture
- api.Document.pictureInPictureElement
- api.Document.pictureInPictureEnabled
Expand All @@ -23,3 +31,28 @@ compat_features:
- api.PictureInPictureWindow.width
- api.ShadowRoot.pictureInPictureElement
- html.elements.video.disablepictureinpicture

# baseline: false
# support:
# chrome: "85"
# chrome_android: "105"
# edge: "85"
# safari: "16"
# safari_ios: "16"
- api.PictureInPictureEvent
- api.PictureInPictureEvent.PictureInPictureEvent
- api.PictureInPictureEvent.pictureInPictureWindow

# baseline: false
# support:
# chrome: "110"
# chrome_android: "110"
# edge: "110"
# safari: "13.1"
# safari_ios: "13.4"
- css.selectors.picture-in-picture

# baseline: false
# support:
# chrome: "88"
- http.headers.Permissions-Policy.picture-in-picture

0 comments on commit 350974e

Please sign in to comment.