Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar should be sticky on mobile when hideNavbar to never #1719

Merged

Conversation

coratgerl
Copy link
Contributor

Summary

Related Issue

Fixes: #1713

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 36ed284
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67726c476cfcc60008a3ab7f
😎 Deploy Preview https://deploy-preview-1719--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Contributor

I think this breaks menu and on this page navs.
image

In mobile scenerio, menu and on this page should be sticky, see #802

Vitepress also takes this behaviour.
20241230144953_rec_

@coratgerl
Copy link
Contributor Author

You right ! I fixed this !

Landing page :
image

Doc page:
image

@Timeless0911 Timeless0911 enabled auto-merge (squash) December 30, 2024 09:54
@Timeless0911 Timeless0911 merged commit 856e3ef into web-infra-dev:main Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Enhance navbar to integrate more configuration
2 participants