Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar link should change url when click on item with hash #1697

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

coratgerl
Copy link
Contributor

Summary

Click on an item that link to an hashtag section should change the url when click. This is useful when we want for example to track where the user click with tools like plausible or unami.

Related Issue

Fixes: #1696

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit ef626cb
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67699890544a5c00087c7833
😎 Deploy Preview https://deploy-preview-1697--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timeless0911 Timeless0911 merged commit bf9f99a into web-infra-dev:main Dec 24, 2024
7 checks passed
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: navbar with hash link doesn't change URL when click
3 participants