Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: head config only takes effect in production mode #1660

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 13, 2024

Summary

update docs, head config only takes effect in production mode.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit ef24e6f
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/675bae511f66b800085e136f
😎 Deploy Preview https://deploy-preview-1660--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from Timeless0911 December 13, 2024 03:49
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it work in dev?

@9aoy
Copy link
Contributor Author

9aoy commented Dec 13, 2024

Can we make it work in dev?

It would be better if dev could support it.

@Timeless0911
Copy link
Contributor

See #1432

I think we can redesign header config in Rspress 2.0 to make it work well in both dev and production mode. Maybe we can directly compose and pass header-related config in config/fronmatter to html.tags config in Rsbuild.

@chenjiahan chenjiahan merged commit 903c799 into main Dec 14, 2024
8 checks passed
@chenjiahan chenjiahan deleted the docs/head-config branch December 14, 2024 11:42
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants