Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable incremental by default #1631

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: enable incremental by default #1631

merged 1 commit into from
Dec 6, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Nov 28, 2024

Summary

Enable incremental by default, user can still disable it by process.env.DISABLE_RSPACK_INCREMENTAL

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 27372f6
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/675298804078860008473ebd
😎 Deploy Preview https://deploy-preview-1631--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk force-pushed the enable-incremental branch from ab9813c to f202ef0 Compare December 6, 2024 06:20
@ahabhgk ahabhgk force-pushed the enable-incremental branch from f202ef0 to 27372f6 Compare December 6, 2024 06:23
@ahabhgk ahabhgk marked this pull request as ready for review December 6, 2024 06:24
@SoonIter SoonIter requested a review from Timeless0911 December 6, 2024 06:26
@Timeless0911
Copy link
Contributor

Can you run pnpm changeset to add a minor changeset for @rspress/core?

@chenjiahan
Copy link
Member

Can you run pnpm changeset to add a minor changeset for @rspress/core?

Changeset added in https://github.com/web-infra-dev/rspress/pull/1643/files

@chenjiahan chenjiahan merged commit 097a700 into main Dec 6, 2024
7 checks passed
@chenjiahan chenjiahan deleted the enable-incremental branch December 6, 2024 13:30
@chenjiahan chenjiahan mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants