Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: when ssg build, init only one rsbuild instance #1169

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Jun 11, 2024

Summary

make clientBuilder and serverBuilder merged into one rsbuild builder

some benefits

  1. make DEBUG mode align with Rsbuild, and debug the ssg build easily
  2. performance better (to be measured)
  3. more maintainable

Related Issue

close #1167

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit a205292
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66853ea86c25b70008d80242
😎 Deploy Preview https://deploy-preview-1169--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Member Author

SoonIter commented Jun 18, 2024

pending with web-infra-dev/rsbuild#2620

Rspress would be the first show case of Rsbuild multi-environment support (SSG)

@SoonIter SoonIter force-pushed the refactor/ssg-build branch 2 times, most recently from d4accac to ca633c9 Compare July 3, 2024 08:29
@SoonIter SoonIter force-pushed the refactor/ssg-build branch from ef9f3c4 to 9851cd2 Compare July 3, 2024 11:12
@SoonIter
Copy link
Member Author

SoonIter commented Jul 3, 2024

Rough estimate of performance

before

image

after

image

@SoonIter SoonIter marked this pull request as ready for review July 3, 2024 11:26
@SoonIter SoonIter enabled auto-merge (squash) July 3, 2024 11:45
@SoonIter SoonIter requested a review from chenjiahan July 4, 2024 03:14
@SoonIter SoonIter merged commit 3b49d67 into web-infra-dev:main Jul 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DEBUG=rsbuild rspress build will delete the generated rspack.config.node.js
3 participants