Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid type error when skipLibCheck is not enabled #7155

Merged
merged 4 commits into from
Jul 15, 2024
Merged

fix: avoid type error when skipLibCheck is not enabled #7155

merged 4 commits into from
Jul 15, 2024

Conversation

CPunisher
Copy link
Contributor

Summary

Checklist

  1. Chaining calls to .or can lead to deep type nesting. Use z.union instead.
  2. Bump chokidar from 3.5.3 to 3.6.0: update fs.FSWatcher types to satisfy nodejs versions >= 16; fixes #1299 paulmillr/chokidar#1300. I also manually update chokidar version of webpack-dev-server in pnpm-lock.yaml since it only bumps in v5(master branch).

Closes: #6481

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jul 15, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 15, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ef8381
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6694d94f839b560008afe90b

chenjiahan
chenjiahan approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@chenjiahan chenjiahan enabled auto-merge (squash) July 15, 2024 08:40
@chenjiahan chenjiahan changed the title fix: avoid type error when skipLibCheck is not on fix: avoid type error when skipLibCheck is not enabled Jul 15, 2024
@chenjiahan chenjiahan disabled auto-merge July 15, 2024 08:40
@chenjiahan chenjiahan enabled auto-merge (squash) July 15, 2024 08:40
@chenjiahan chenjiahan merged commit f93ce95 into web-infra-dev:main Jul 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Avoid type error from @rspack/core/dist/config/zod.d.ts when skipLibCheck is not on
2 participants
@CPunisher @chenjiahan