Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support test, include and exclude options for SwcCssMinimizerRspackPlugin #7111

Merged

Conversation

simonxabris
Copy link
Contributor

@simonxabris simonxabris commented Jul 10, 2024

Summary

The PR adds the test, include and exclude options to the SwcCssMinimizerRspackPlugin, similar to how it works with the SwcJsMinimizerRspackPlugin.

resolve #6898

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7d15fb7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66936e37e981f800092e297e

@simonxabris simonxabris force-pushed the feat/swc-css-minimizer-options branch from fd11a95 to 3771993 Compare July 10, 2024 19:13
packages/rspack/etc/api.md Outdated Show resolved Hide resolved
@xc2
Copy link
Collaborator

xc2 commented Jul 13, 2024

would you please also impl these options for LightningCssMinimizerRspackPlugin?

Related #7135

@simonxabris
Copy link
Contributor Author

would you please also impl these options for LightningCssMinimizerRspackPlugin?

Related #7135

Absolutely, on it!

Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, needs rebase and CI should pass

@ahabhgk
Copy link
Contributor

ahabhgk commented Jul 13, 2024

would you please also impl these options for LightningCssMinimizerRspackPlugin?

You can finish it in another PR, let's keep this PR only for SwcCssMinimizerRspackPlugin

@simonxabris simonxabris changed the title feat: support test, include and exclude options for SwcCssMinimizerRspackPlugin` feat: support test, include and exclude options for SwcCssMinimizerRspackPlugin Jul 13, 2024
@simonxabris simonxabris force-pushed the feat/swc-css-minimizer-options branch from 30c1809 to c3a028e Compare July 13, 2024 18:06
ahabhgk
ahabhgk previously approved these changes Jul 14, 2024
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahabhgk ahabhgk enabled auto-merge (squash) July 14, 2024 04:59
auto-merge was automatically disabled July 14, 2024 06:20

Head branch was pushed to by a user without write access

@ahabhgk ahabhgk enabled auto-merge (squash) July 14, 2024 06:43
@ahabhgk ahabhgk merged commit 7540e88 into web-infra-dev:main Jul 14, 2024
31 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: support for exclude option by SwcCssMinimizerRspackPlugin
4 participants