Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add panic handler #4849

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat: add panic handler #4849

merged 1 commit into from
Dec 4, 2023

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Dec 1, 2023

Summary

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@h-a-n-a h-a-n-a mentioned this pull request Dec 1, 2023
Merged
2 tasks
@h-a-n-a Graphite App
Copy link
Collaborator Author

h-a-n-a commented Dec 1, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 1, 2023
@h-a-n-a h-a-n-a force-pushed the 12-01-feat_add_panic_handler branch from c07408a to c91abc8 Compare December 4, 2023 03:47
@h-a-n-a h-a-n-a force-pushed the 12-01-feat_add_panic_handler branch from c91abc8 to bfe6fef Compare December 4, 2023 03:54
@h-a-n-a h-a-n-a marked this pull request as ready for review December 4, 2023 04:08
@h-a-n-a h-a-n-a requested a review from ahabhgk December 4, 2023 04:09
@h-a-n-a Graphite App
Copy link
Collaborator Author

h-a-n-a commented Dec 4, 2023 •
edited
Loading

Merge activity

  • Dec 3, 11:15 PM: @h-a-n-a started a stack merge that includes this pull request via Graphite.
  • Dec 3, 11:15 PM: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

@h-a-n-a h-a-n-a merged commit 355c0f0 into 12-01-feat_do_not_convert_panics_to_results Dec 4, 2023
17 checks passed
@h-a-n-a h-a-n-a deleted the 12-01-feat_add_panic_handler branch December 4, 2023 04:15
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2023
@h-a-n-a
feat: do not convert panics to results (#4848)
0a53587 
* feat: do not convert panics to results

* feat: add panic handler (#4849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @ahabhgk