feat: align module error

web-infra-dev · Dec 5, 2023 · d8388ff · d8388ff
1 parent 2155d7d
commit d8388ff
Show file tree

Hide file tree

Showing 21 changed files with 559 additions and 587 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/rspack_binding_options/src/options/raw_module/js_loader.rs b/crates/rspack_binding_options/src/options/raw_module/js_loader.rs
@@ -322,7 +322,10 @@ impl TryFrom<&rspack_core::LoaderContext<'_, rspack_core::LoaderRunnerContext>>
 
       additional_data_external: External::new(cx.additional_data.clone()),
       context_external: External::new(cx.context.clone()),
-      diagnostics_external: External::new(cx.__diagnostics.clone()),
+      diagnostics_external: External::new({
+        eprintln!("Should be able to pipe diagnostic errors");
+        vec![]
+      }),
     })
   }
 }

diff --git a/crates/rspack_core/src/cache/mod.rs b/crates/rspack_core/src/cache/mod.rs
@@ -14,7 +14,10 @@ mod snapshot;
 mod storage;
 pub use local::*;
 use occasion::{
-  BuildModuleOccasion, CodeGenerateOccasion, CreateChunkAssetsOccasion, ResolveModuleOccasion,
+  // BuildModuleOccasion,
+  CodeGenerateOccasion,
+  CreateChunkAssetsOccasion,
+  ResolveModuleOccasion,
 };
 use snapshot::SnapshotManager;
 use storage::new_storage;
@@ -24,7 +27,7 @@ pub struct Cache {
   is_idle: AtomicBool,
   snapshot_manager: Arc<SnapshotManager>,
   pub resolve_module_occasion: ResolveModuleOccasion,
-  pub build_module_occasion: BuildModuleOccasion,
+  // pub build_module_occasion: BuildModuleOccasion,
   pub code_generate_occasion: CodeGenerateOccasion,
   pub create_chunk_assets_occasion: CreateChunkAssetsOccasion,
 }
@@ -39,10 +42,10 @@ impl Cache {
         new_storage(&options.cache),
         snapshot_manager.clone(),
       ),
-      build_module_occasion: BuildModuleOccasion::new(
-        new_storage(&options.cache),
-        snapshot_manager,
-      ),
+      // build_module_occasion: BuildModuleOccasion::new(
+      //   new_storage(&options.cache),
+      //   snapshot_manager,
+      // ),
       code_generate_occasion: CodeGenerateOccasion::new(new_storage(&options.cache)),
       create_chunk_assets_occasion: CreateChunkAssetsOccasion::new(new_storage(&options.cache)),
     }