refactor: error and diagnostics

crates/rspack_core/src/tree_shaking/optimizer.rs

@@ -1067,10 +1067,10 @@ impl<'a> CodeSizeOptimizer<'a> {
                   })
                   .collect::<Vec<_>>();
                 error_message += &join_string_component(module_identifier_list);
-                errors.push(Error::InternalError(InternalError {
+                errors.push(Error::InternalError(InternalError::new(
                   error_message,
-                  severity: Severity::Warn,
-                }));
+                  Severity::Warn,
+                )));
                 ret[0].1.clone()
               }
             };
@@ -1101,10 +1101,10 @@ impl<'a> CodeSizeOptimizer<'a> {
                 .normal_module_source_path_by_identifier(&star_symbol.src());
               if let Some(module_path) = module_path {
                 let error_message = format!("Can't get analyze result of {module_path}");
-                errors.push(Error::InternalError(InternalError {
+                errors.push(Error::InternalError(InternalError::new(
                   error_message,
-                  severity: Severity::Warn,
-                }));
+                  Severity::Warn,
+                )));
               }
             }
             return;

crates/rspack_error/Cargo.toml

@@ -11,12 +11,14 @@ version    = "0.1.0"
 anyhow             = { workspace = true, features = ["backtrace"] }
 codespan-reporting = { version = "=0.11.2", package = "rspack-codespan-reporting" }
 futures            = { workspace = true }
+miette             = { version = "5", features = ["fancy"] }
 rspack_sources     = { workspace = true }
 rspack_util        = { path = "../rspack_util" }
 serde_json         = { workspace = true }
 sugar_path         = { workspace = true }
 swc_core           = { workspace = true, features = ["common"] }
 termcolor          = "1.2"
+thiserror          = "1"
 
 [dev-dependencies]
 insta = { workspace = true }

crates/rspack_error/src/diagnostic.rs

@@ -9,6 +9,15 @@ pub enum Severity {
   Warn,
 }
 
+impl From<Severity> for miette::Severity {
+  fn from(value: Severity) -> Self {
+    match value {
+      Severity::Error => miette::Severity::Error,
+      Severity::Warn => miette::Severity::Warning,
+    }
+  }
+}
+
 impl fmt::Display for Severity {
   fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
     write!(
@@ -87,11 +96,11 @@ impl From<Error> for Vec<Diagnostic> {
     let severity = err.severity();
     let diagnostic = match err {
       Error::InternalError(err) => Diagnostic {
-        message: err.error_message,
+        message: err.error_message().to_string(),
         source_info: None,
         start: 0,
         end: 0,
-        severity: err.severity,
+        severity: err.severity(),
         ..Default::default()
       },
       Error::Napi {

crates/rspack_error/src/error.rs

@@ -1,33 +1,39 @@
 use std::{fmt, io, path::Path};
 
+use miette::MietteDiagnostic;
 use rspack_util::swc::normalize_custom_filename;
 use swc_core::common::SourceFile;
 
 use crate::{internal_error, Severity};
 
-#[derive(Debug, Default)]
-pub struct InternalError {
-  pub error_message: String,
-  pub severity: Severity,
-}
+#[derive(Debug)]
+pub struct InternalError(MietteDiagnostic);
 
 impl InternalError {
   pub fn new(error_message: String, severity: Severity) -> Self {
-    Self {
-      error_message,
-      severity,
-    }
+    Self(MietteDiagnostic::new(error_message.clone()).with_severity(severity.into()))
   }
 
-  pub fn with_severity(mut self, severity: Severity) -> Self {
-    self.severity = severity;
-    self
+  pub fn with_severity(self, severity: Severity) -> Self {
+    Self(self.0.with_severity(severity.into()))
+  }
+
+  pub fn error_message(&self) -> &str {
+    &self.0.message
+  }
+
+  pub fn severity(&self) -> Severity {
+    match self.0.severity.expect("severity should available") {
+      miette::Severity::Advice => unreachable!(),
+      miette::Severity::Warning => Severity::Warn,
+      miette::Severity::Error => Severity::Error,
+    }
   }
 }
 
 impl fmt::Display for InternalError {
   fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-    writeln!(f, "{}[internal]: {}", self.severity, self.error_message)
+    writeln!(f, "{}[internal]: {}", self.severity(), self.0.message)
   }
 }
 

crates/rspack_error/src/lib.rs

@@ -11,6 +11,9 @@ pub mod emitter;
 
 mod macros;
 
+pub use miette;
+pub use thiserror;
+
 pub type Result<T> = std::result::Result<T, Error>;
 
 /// A helper struct for change logic from
@@ -81,6 +84,7 @@ impl<T: Sized + std::fmt::Debug> IntoTWithDiagnosticArray for T {
 pub mod __private {
   pub use core::result::Result::Err;
 
+  pub use crate::diagnostic::Severity;
   pub use crate::error::{Error, InternalError};
   pub use crate::internal_error;
 }

crates/rspack_error/src/macros.rs

@@ -1,12 +1,9 @@
 #[macro_export]
 macro_rules! internal_error {
   (@base $expr:expr) => {
-    $crate::__private::Error::InternalError({
-      $crate::__private::InternalError {
-        error_message: $expr,
-        ..Default::default()
-      }
-    })
+    $crate::__private::Error::InternalError(
+      $crate::__private::InternalError::new($expr, $crate::__private::Severity::Error)
+    )
   };
   ($str:literal $(,)?) => {{
     let err = format!($str);

crates/rspack_loader_sass/src/lib.rs

@@ -473,16 +473,16 @@ impl Loader<LoaderRunnerContext> for SassLoader {
     let sass_options = self.get_sass_options(loader_context, content.try_into_string()?, logger);
     let result = Sass::new(&self.options.__exe_path)
       .map_err(|e| {
-        rspack_error::Error::InternalError(InternalError {
-          severity: Severity::Error,
-          error_message: format!(
+        rspack_error::Error::InternalError(InternalError::new(
+          format!(
             "{}: The dart-sass-embedded path is {}, your OS is {}, your Arch is {}",
             e.message(),
             &self.options.__exe_path.display(),
             get_os(),
             get_arch(),
           ),
-        })
+          Severity::Error,
+        ))
       })?
       .render(sass_options)
       .map_err(sass_exception_to_error)?;

crates/rspack_plugin_ensure_chunk_conditions/src/lib.rs

@@ -66,10 +66,10 @@ impl Plugin for EnsureChunkConditionsPlugin {
                 }
               }
               if chunk_group.is_initial() {
-                return Err(Error::InternalError(rspack_error::InternalError {
-                  error_message: format!("Cannot fulfil chunk condition of {}", module_id),
-                  severity: Default::default(),
-                }));
+                return Err(Error::InternalError(rspack_error::InternalError::new(
+                  format!("Cannot fulfil chunk condition of {}", module_id),
+                  Default::default(),
+                )));
               }
               let parent_chunks = chunk_group.parents_iterable();