Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix unsable CORS cases #4195

Merged
merged 1 commit into from
Dec 14, 2024
Merged

test(e2e): fix unsable CORS cases #4195

merged 1 commit into from
Dec 14, 2024

Conversation

chenjiahan
Copy link
Member

Summary

The CORS e2e cases are unstable in the Windows CI:

    Error: apiRequestContext.get: connect ECONNREFUSED ::1:24257
    Call log:
      - → GET http://localhost:24257/
      -   user-agent: Playwright/1.44.1 (x64; windows 10.0) node/22.12 CI/1
      -   accept: */*
      -   accept-encoding: gzip,deflate,br


        at D:\a\rsbuild\rsbuild\e2e\apiRequestContext.get: connect ECONNREFUSED ::1:24257
        at D:\a\rsbuild\rsbuild\e2e\cases\server\cors\index.test.ts:45:34

Possible solution: https://stackoverflow.com/questions/74567328/api-get-request-test-using-playwright

Related Links

https://github.com/web-infra-dev/rsbuild/actions/runs/12328244091/job/34411201012?pr=4194#step:7:1838

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 14b56de
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/675d43d004ba3e00085317c3
😎 Deploy Preview https://deploy-preview-4195--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 5d5c725 into main Dec 14, 2024
10 checks passed
@chenjiahan chenjiahan deleted the e2e_cors_cases_1214 branch December 14, 2024 09:37
@9aoy 9aoy mentioned this pull request Dec 20, 2024
@chenjiahan chenjiahan mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant