Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server.cors config #4183

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: add server.cors config #4183

merged 2 commits into from
Dec 13, 2024

Conversation

chenjiahan
Copy link
Member

Summary

This pull request introduces CORS support across the dev and preview servers, along with corresponding tests and configuration updates. The most important changes include adding CORS middleware (based on https://github.com/expressjs/cors), updating server configurations, and adding tests to ensure CORS functionality.

Documentation will be updated later.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c339fa3
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/675b9d1d727df000084210bf
😎 Deploy Preview https://deploy-preview-4183--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan mentioned this pull request Dec 13, 2024
2 tasks
@chenjiahan chenjiahan merged commit 86fca15 into main Dec 13, 2024
9 checks passed
@chenjiahan chenjiahan deleted the server_cors_1212 branch December 13, 2024 03:07
@9aoy 9aoy mentioned this pull request Dec 20, 2024
@chenjiahan chenjiahan mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants