Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): use html-webpack-plugin by default #4175

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Use html-webpack-plugin in @rsbuild/webpack by default.

This allows us to:

  • Remove __internalHelper from @rsbuild/core. We no longer need to export the helper for Modern.js
  • @rsbuild/core can switch to the Rust HtmlRspackPlugin in the future.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from 9aoy December 11, 2024 09:00
@chenjiahan chenjiahan changed the title fix(webpack): use html-webpack-plugin fix(webpack): use html-webpack-plugin by default Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3efa3bb
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6759549de951f40008e584d4
😎 Deploy Preview https://deploy-preview-4175--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) December 11, 2024 09:07
@chenjiahan chenjiahan merged commit 91eb650 into main Dec 11, 2024
11 checks passed
@chenjiahan chenjiahan deleted the webpack_html_1211 branch December 11, 2024 09:09
@9aoy 9aoy mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants