Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not trigger dev hooks when building #4165

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Dec 10, 2024

Summary

  • Should not trigger dev hooks when building.
  • Added command property to the internal context.

Related Links

#4164

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1b9753d
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6757fa8380bd990008a8562e
😎 Deploy Preview https://deploy-preview-4165--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 464fdd7 into main Dec 10, 2024
11 checks passed
@chenjiahan chenjiahan deleted the dev_hooks_1210 branch December 10, 2024 11:36
@9aoy 9aoy mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant