Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make environment API result cacheable #4126

Merged
merged 7 commits into from
Dec 5, 2024
Merged

feat: make environment API result cacheable #4126

merged 7 commits into from
Dec 5, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 5, 2024 •
edited
Loading

Summary

make loadBundle and getTransformedHtml result cacheable.

Related Links

#4038

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 394c8ea
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67517301d01d530008814c25
😎 Deploy Preview https://deploy-preview-4126--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 82 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Dec 5, 2024
View reviewed changes
e2e/cases/server/ssr/index.test.ts Outdated Show resolved Hide resolved
e2e/cases/server/ssr/src/index.server.tsx Outdated Show resolved Hide resolved
packages/core/src/server/environment.ts Outdated Show resolved Hide resolved
packages/core/src/server/environment.ts Outdated Show resolved Hide resolved
@chenjiahan chenjiahan enabled auto-merge (squash) December 5, 2024 09:33
@chenjiahan chenjiahan merged commit 172d99f into main Dec 5, 2024
9 checks passed
@chenjiahan chenjiahan deleted the feat/load-bundle-cacheable branch December 5, 2024 09:39
@chenjiahan chenjiahan mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9aoy @chenjiahan