Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix SSR Node bundle usage in docs #4076

Merged
merged 1 commit into from
Nov 28, 2024
Merged

docs: fix SSR Node bundle usage in docs #4076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/docs/en/guide/advanced/ssr.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ import { createRsbuild, loadConfig } from '@rsbuild/core';

// Implement SSR rendering function
const serverRender = (serverAPI) => async (_req, res) => {
// Load SSR bundle
const indexModule = await serverAPI.environments.ssr.loadBundle('index');
// Load Node bundle for SSR
const indexModule = await serverAPI.environments.node.loadBundle('index');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use environments.node instead of environments.ssr. @9aoy what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer environments.node. I will check other places where environments.ssr is used and correct it


const markup = indexModule.render();

Expand Down
Loading