Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable module trace by default #4008

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Nov 18, 2024

Summary

Enable moduleTrace by default.

image

Related Links

#3986

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit afccd25
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/673abf7be7d4420008df9164
😎 Deploy Preview https://deploy-preview-4008--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title chore: enable module trace by default feat: enable module trace by default Nov 18, 2024
@@ -45,7 +45,7 @@
"typescript": "^5.6.3"
},
"peerDependencies": {
"@rsbuild/core": "^1.1.2"
"@rsbuild/core": "^1.1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to bump this version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize stats with getStatsOptions is supported in rsbuild 1.1.3.
#3987

@chenjiahan chenjiahan merged commit 54d3885 into main Nov 18, 2024
9 checks passed
@chenjiahan chenjiahan deleted the enable-module-trace-by-default branch November 18, 2024 04:53
@9aoy 9aoy mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants