Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-sass): mute deprecation warnings of dependencies #3998

Merged
merged 2 commits into from
Nov 17, 2024
Merged

feat(plugin-sass): mute deprecation warnings of dependencies #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab161b6
feat(plugin-sass): mute deprecation warnings of dependencies
chenjiahan Nov 17, 2024
3c1db9e
fix
chenjiahan Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/plugin-sass/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ const getSassLoaderOptions = (
sourceMap: isUseCssSourceMap,
api: 'modern-compiler',
implementation: require.resolve('sass-embedded'),
sassOptions: {
// mute deprecation warnings of dependencies
quietDeps: true,
},
},
config: userOptions,
ctx: { addExcludes },
Expand Down
10 changes: 10 additions & 0 deletions packages/plugin-sass/tests/__snapshots__/index.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ exports[`plugin-sass > should add sass-loader 1`] = `
"options": {
"api": "modern-compiler",
"implementation": "<ROOT>/node_modules/<PNPM_INNER>/sass-embedded/dist/lib/index.js",
"sassOptions": {
"quietDeps": true,
},
"sourceMap": true,
},
},
Expand Down Expand Up @@ -106,6 +109,9 @@ exports[`plugin-sass > should add sass-loader and css-loader when injectStyles 1
"options": {
"api": "modern-compiler",
"implementation": "<ROOT>/node_modules/<PNPM_INNER>/sass-embedded/dist/lib/index.js",
"sassOptions": {
"quietDeps": true,
},
"sourceMap": true,
},
},
Expand Down Expand Up @@ -166,6 +172,9 @@ exports[`plugin-sass > should add sass-loader with excludes 1`] = `
"options": {
"api": "modern-compiler",
"implementation": "<ROOT>/node_modules/<PNPM_INNER>/sass-embedded/dist/lib/index.js",
"sassOptions": {
"quietDeps": true,
},
"sourceMap": true,
},
},
Expand Down Expand Up @@ -224,6 +233,7 @@ exports[`plugin-sass > should allow to use legacy API and mute deprecation warni
"api": "legacy",
"implementation": "<ROOT>/node_modules/<PNPM_INNER>/sass-embedded/dist/lib/index.js",
"sassOptions": {
"quietDeps": true,
"silenceDeprecations": [
"legacy-js-api",
],
Expand Down
4 changes: 4 additions & 0 deletions website/docs/en/plugins/list/plugin-sass.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ const defaultOptions = {
api: 'modern-compiler',
implementation: require.resolve('sass-embedded'),
sourceMap: rsbuildConfig.output.sourceMap.css,
sassOptions: {
quietDeps: true,
silenceDeprecations: api === 'legacy' ? ['legacy-js-api'] : undefined,
},
};
```

Expand Down
4 changes: 4 additions & 0 deletions website/docs/zh/plugins/list/plugin-sass.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ const defaultOptions = {
api: 'modern-compiler',
implementation: require.resolve('sass-embedded'),
sourceMap: rsbuildConfig.output.sourceMap.css,
sassOptions: {
quietDeps: true,
silenceDeprecations: api === 'legacy' ? ['legacy-js-api'] : undefined,
},
};
```

Expand Down
Loading