Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add explanation to .env #3993

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

hangCode2001
Copy link
Contributor

Summary

I think the variables that the client can access should be stated at the beginning of .env.
image
Where the .env file is loaded manually, our example will pass publicVars to source.define. The default value of publicVars should also be briefly commented to avoid misleading people.
image

Related Links

#3975

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ebf778b
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67388294d87fd90008aadc06
😎 Deploy Preview https://deploy-preview-3993--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

website/docs/zh/guide/advanced/env-vars.mdx Outdated Show resolved Hide resolved
website/docs/zh/guide/advanced/env-vars.mdx Outdated Show resolved Hide resolved
website/docs/en/guide/advanced/env-vars.mdx Outdated Show resolved Hide resolved
website/docs/en/guide/advanced/env-vars.mdx Outdated Show resolved Hide resolved
@chenjiahan chenjiahan enabled auto-merge (squash) November 16, 2024 11:31
@chenjiahan chenjiahan merged commit dc9e4f7 into web-infra-dev:main Nov 16, 2024
9 checks passed
@chenjiahan
Copy link
Member

Thank you!

@chenjiahan chenjiahan mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants