Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move runCLI from internal helpers to index export #3981

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Move runCLI from internal helpers to index export.

Motivations:

  • To remove all internal helpers.
  • runCLI now can be used as a public API, it is still undocumented, but users can use it. So we will keep it stable and simple.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from 9aoy November 15, 2024 02:56
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b859ef2
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6736b86e8159000008cbf3b4
😎 Deploy Preview https://deploy-preview-3981--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit b6745f0 into main Nov 15, 2024
10 checks passed
@chenjiahan chenjiahan deleted the run_cli_1115 branch November 15, 2024 03:12
@chenjiahan chenjiahan mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant