fix: onBeforeBuild hook should before onBeforeEnvironmentCompile hook #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Aug 13, 2024
packages/core/src/hooks.ts
Outdated
|
|
||
| if (lastCompilerDone) { | ||
| await beforeCompile?.(); | ||
| if (isFirstTrigger) { |
There was a problem hiding this comment.
It seems we do not need a isFirstTrigger variable:
Suggested change
| if (isFirstTrigger) { | |
| if (!waitBeforeCompileDone) { |
There was a problem hiding this comment.
doneCompilers is not reliable as it can decrease in some cases.
chenjiahan
approved these changes
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix build hooks order,
onBeforeBuildhook should before allonBeforeEnvironmentCompilehooks run.Related Links
Checklist