Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new mode config #3155

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: add new mode config #3155

merged 4 commits into from
Aug 7, 2024

Conversation

chenjiahan
Copy link
Member

Summary

In the past, Rsbuild internally relied too much on process.env.NODE_ENV, which resulted in coupling between the build mode and NODE_ENV.

This PR introduces a new mode config for Rsbuild. This config is similar to Rspack's mode config and can be used to specify the build mode of Rsbuild without needing to modify process.env.NODE_ENV.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 93c5d9c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66b37d75adc7850008145fcd
😎 Deploy Preview https://deploy-preview-3155--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 9163ca4 into main Aug 7, 2024
10 checks passed
@chenjiahan chenjiahan deleted the mode_config_0807 branch August 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant