Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-sass): sassOptions type should defaults to modern API #3143

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

chenjiahan
Copy link
Member

Summary

sassOptions type should defaults to modern API, because sass-loader >= 16.0.0 uses modern API by default.

Related Links

https://github.com/webpack-contrib/sass-loader/releases/tag/v16.0.0
#2708

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 16b0f51
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66b1f88eda394000080c85e4
😎 Deploy Preview https://deploy-preview-3143--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 037da7b into main Aug 6, 2024
10 checks passed
@chenjiahan chenjiahan deleted the sass_options_type_0806 branch August 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant