-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more plugins support used as environment plugin #2994
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -57,39 +59,43 @@ export const pluginStyledComponents = ( | |||
}); | |||
}; | |||
|
|||
// use modifyRsbuildConfig to get useSSR default value (can be override by pluginOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective, we should not use the modifyRsbuildConfig
to get
config.
If we want to get the config, we can use api.getRsbuildConfig()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling api.getRsbuildConfig()
in modifyEnvironmentConfig hook is currently not supported because RsbuildConfig contains EnvironmentConfig, which has not yet been determined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get it!
Summary
use
modifyEnvironmentConfig
instead ofmodifyRsbuildConfig
, make more plugins support used as environment plugin.Related Links
#2986
Checklist