Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude method options when checking [hash].hot-update.json #2977

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: exclude method options when checking [hash].hot-update.json #2977

merged 1 commit into from
Jul 22, 2024

Conversation

huuduy005
Copy link
Contributor

Summary

Addressed an issue causing HTTP 404 errors for [hash].hot-update.json files when using the OPTIONS method, leading to CORS problems.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Jul 21, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 4525929
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/669d1d0595d6370008a29f85
😎 Deploy Preview https://deploy-preview-2977--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from 9aoy July 21, 2024 23:58
@9aoy 9aoy merged commit 16bc758 into web-infra-dev:main Jul 22, 2024
11 checks passed
@chenjiahan chenjiahan mentioned this pull request Jul 22, 2024
Merged
@huuduy005 huuduy005 deleted the fix/exclude-method-options-case-404-hot-update-json branch July 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9aoy 9aoy 9aoy approved these changes

Assignees
No one assigned
Labels
release: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huuduy005 @CLAassistant @9aoy