Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix plugins type mismatch #2875

Merged
merged 1 commit into from
Jul 11, 2024
Merged

types: fix plugins type mismatch #2875

merged 1 commit into from
Jul 11, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Support for registering lower version Rsbuild plugins in the new version of Rsbuild core without throwing type mismatches.

In most cases, Rsbuild core only adds new methods or properties to the API object, which means that lower version plugins will usually work fine.

Fix the following error:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0bdd03f
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668f53466cda2100080121b3
😎 Deploy Preview https://deploy-preview-2875--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit c632407 into main Jul 11, 2024
11 checks passed
@chenjiahan chenjiahan deleted the plugin_type_0711 branch July 11, 2024 03:46
@9aoy 9aoy mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant