Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use canary specific version instead of npm tag #2720

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

SoonIter
Copy link
Member

Summary

https://github.com/web-infra-dev/web-infra-QoS/blob/c9e4cb93b3c89fb63484f6c0646c612af9071d30/scripts/src/shared/git.ts#L78-L79

We don't use --frozen-lockfile here because of the cases workspace.

then get the installment result below 😅

old-canary-version(in lockfile): 0.7.5-canary-6253334-20240626035254
new-canary-version: 0.7.5-canary-cff3bb0-20240627062412

@rspack/core-canary@old-canary-version
└── @rspack/binding-canary@new-canary-version
    └──  @rspack/binding-linux-x64-gnu-canary@new-canary-version

and we get the error

https://github.com/web-infra-dev/rspack/blob/b157267cfe989e0b45d88220945741f5382b96e1/packages/rspack/src/util/bindingVersionCheck.ts#L136

This error does not seem to terminate the entire dev process, causing our ci to be stuck.

Related Links

https://github.com/web-infra-dev/web-infra-QoS/actions/runs/9707169745/job/26791932553

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6b8f1d5
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/667e51f2432edd0008690cc4
😎 Deploy Preview https://deploy-preview-2720--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) June 28, 2024 06:04
@chenjiahan chenjiahan merged commit c09a492 into web-infra-dev:main Jun 28, 2024
10 checks passed
@Timeless0911
Copy link
Contributor

Can we write a simple script to bump rspack canary version automatically?

@SoonIter
Copy link
Member Author

Can we write a simple script to bump rspack canary version automatically?

🚀🚀🚀 CI=true npx install-rspack --version canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants