Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove service-worker target #2657

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jun 21, 2024

Summary

BREAKING CHANGE: Remove output.target: 'service-worker', use output.target: 'web-worker' instead.
BREAKING CHANGE: Remove output.distPath.worker, use environment configuration instead.
BREAKING CHANGE: Remove isServiceWorker param of tools.rspack config, use target === 'web-worker' instead.

Related Links

#2620

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan changed the title refactor: remove service-worker target refactor!: remove service-worker target Jun 21, 2024
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c6cf4e0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66753933bc972b0008211038
😎 Deploy Preview https://deploy-preview-2657--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 7a1e461 into main Jun 21, 2024
6 checks passed
@chenjiahan chenjiahan deleted the remove_service_worker_target_0621 branch June 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant