Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support apply environment html-related config #2647

Merged

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jun 20, 2024

Summary

  • feat: support apply environment html-related config
  • feat: add htmlPaths to context.environments
  • feat: add environment param to api.modifyHTMLTags context and api.getHTMLPaths
  • fix: defaultEntry should apply to environment config instead of RsbuildConfig
const Myplugin = (): RsbuildPlugin => ({
  setup(api) {
    api.modifyBundlerChain((chain, { environment }) => {
      const { htmlPaths } = api.context.environments[environment];
      console.log(htmlPaths);
    });
    api.modifyHTMLTags({ headTags, bodyTags }, { environment }) => {
        const config = api.getNormalizedConfig({ environment });
        console.log(config);
    });
  },
});

Related Links

#2508

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit bf3e0f5
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6674e7800a841a00083251c7
😎 Deploy Preview https://deploy-preview-2647--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) June 21, 2024 02:46
@chenjiahan chenjiahan merged commit 6009601 into web-infra-dev:main Jun 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants