fix

web-infra-dev · Sep 11, 2024 · bc30932 · bc30932
1 parent ff2d005
commit bc30932
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/packages/compat/webpack/tests/__snapshots__/webpackConfig.test.ts.snap b/packages/compat/webpack/tests/__snapshots__/webpackConfig.test.ts.snap
@@ -8,9 +8,6 @@ exports[`webpackConfig > should allow to append and prepend plugins 1`] = `
     },
   },
   RsbuildCorePlugin {},
-  HotModuleReplacementPlugin {
-    "options": {},
-  },
   MiniCssExtractPlugin {
     "_sortedModulesCache": WeakMap {},
     "options": {

diff --git a/packages/core/src/plugins/basic.ts b/packages/core/src/plugins/basic.ts
@@ -17,7 +17,7 @@ export const pluginBasic = (): RsbuildPlugin => ({
 
   setup(api) {
     api.modifyBundlerChain(
-      (chain, { env, isProd, target, bundler, environment, CHAIN_ID }) => {
+      (chain, { env, isDev, target, bundler, environment, CHAIN_ID }) => {
         const { config } = environment;
 
         chain.name(environment.name);
@@ -46,7 +46,7 @@ export const pluginBasic = (): RsbuildPlugin => ({
           },
         });
 
-        const usingHMR = !isProd && config.dev.hmr && target === 'web';
+        const usingHMR = isDev && config.dev.hmr && target === 'web';
 
         if (usingHMR) {
           chain

diff --git a/packages/plugin-react/src/react.ts b/packages/plugin-react/src/react.ts
@@ -45,9 +45,9 @@ export const applyBasicReactSupport = (
   });
 
   api.modifyBundlerChain(
-    async (chain, { CHAIN_ID, environment, isProd, target }) => {
+    async (chain, { CHAIN_ID, environment, isDev, target }) => {
       const { config } = environment;
-      const usingHMR = !isProd && config.dev.hmr && target === 'web';
+      const usingHMR = isDev && config.dev.hmr && target === 'web';
       if (!usingHMR) {
         return;
       }