Optimize: don't allocate memory

Signed-off-by: Raul Metsma <[email protected]>
web-eid · Sep 20, 2024 · 2420a3d · 2420a3d
1 parent 477a757
commit 2420a3d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp-utils.hpp b/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp-utils.hpp
@@ -43,10 +43,10 @@ inline std::string int2hexstr(const T value)
 
 /** Remove absolute path prefix until 'src' from the given path, '/path/to/src/main.cpp' becomes
  * 'src/main.cpp'. */
-inline std::string removeAbsolutePathPrefix(std::string filePath)
+constexpr const char* removeAbsolutePathPrefix(std::string_view filePath)
 {
     const auto lastSrc = filePath.rfind("src");
-    return lastSrc == std::string::npos ? std::move(filePath) : filePath.erase(0, lastSrc);
+    return lastSrc == std::string::npos ? filePath.data() : filePath.substr(lastSrc).data();
 }
 
 } // namespace pcsc_cpp

diff --git a/lib/libpcsc-cpp/src/listReaders.cpp b/lib/libpcsc-cpp/src/listReaders.cpp
@@ -49,7 +49,7 @@ std::vector<const string_t::value_type*> getReaderNamePointerList(const string_t
     if (readerNames.empty())
         return readerNamePointerList;
 
-        // Reader names are \0 separated and end with double \0.
+    // Reader names are \0 separated and end with double \0.
 #ifdef _WIN32
     for (const string_t::value_type* name = readerNames.c_str(); *name; name += wcslen(name) + 1) {
 #else