Add busy loop to wait for instance to be ssh'able #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
antas-marcin
approved these changes
Dec 10, 2024
We are getting recently errors that the SSH key didn't have time enought to propage. This PR adds a busy loop to wait for SSH to be ready. Also, it was missed to add cleanup for AWS in the quantization script variant.
jfrancoa
force-pushed
the
jose/clean-gcp-keys
branch
from
2c5ae5a to
51c9a2f
Compare
|
This PR messed up with all the SSH keys stored in the project, the good news is that the limit isn't reached anymore but all of them got cleaned up. |
jfrancoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting recently errors that the SSH key didn't have
time enought to propage. This PR adds a busy loop to wait for SSH to be ready.
Also, it was missed to add cleanup for AWS in the quantization script variant.