Make the ann-benchmark AWS instance deletion resilient. #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noted that some of the AWS instances didn't cleanup properly, incurring in extra costs from our AWS EC2 account. This commit makes sure that the instance gets deleted and if for whatever reason it didn't after 5 minutes, the job will fail. So that the person monitoring the job can take a look at the AWS' instances or escalate the issue to SRE.