Fix NPE with unresponsive Weaviate server #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unresponsive weaviate server will cause a NPE and the unit test added here reproduces that NPE.
The weaviate client will ocasionally return null when calling result.getResult. This can happen when the Weaviate server is not accessible or when the Weaviate server is overloaded and not able to return a response temporarily.
antas-marcin
approved these changes
May 9, 2023
|
Great to see you again! Thanks for the contribution. |
|
Confirmed with end-user in #85 that this PR indeed solves their specific NPE and now throws an informative error message. The error message of the end-user now shows a timeout like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unresponsive weaviate server will cause a NPE when calling
result.getResult. This PR adds a check to see if result.getResult == null and if so retry and if retries are 0 then throw a Weaviate specific exception with error message from Weaviate.This fixes #85