Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix xtables.lock race condition between weave and kube-proxy. #3353

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

louismunro
Copy link

Creates a new prog/weave-kube/weave-daemonset-k8s-1.8.yaml with type "FileOrCreate" based on the existing 1.7 one.
I tried to take care of the release and testing too but I might be missing something. Feel free to correct me if that's the case.

Fixes #3351

@louismunro
Copy link
Author

:-(
circle-test-smoke seems to expect a secret key.
Was I meant to provide it as part of the PR?

@murali-reddy
Copy link
Contributor

Was I meant to provide it as part of the PR?

No, There are limitation w.r.t secrets to run CI against forked repo PR's. I pushed the branch to main repo. CI looks good.

@bboreham
Copy link
Contributor

Why is this different to #3134 ?

@bboreham
Copy link
Contributor

Oh, I see, it's FileOrCreate, just as you said.

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

BTW, just to check, I did:

$ diff weave-daemonset-k8s-1.7.yaml weave-daemonset-k8s-1.8.yaml 
206a207
>                 type: FileOrCreate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants