Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: cancel on new commits #3733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Actions: cancel on new commits #3733

wants to merge 2 commits into from

Conversation

morancj
Copy link
Member

@morancj morancj commented May 30, 2023

Cancel Actions workflows on new commits

What changed?

Cancel Actions workflows on new commits.

Why was this change made?

Speed up CI, lower costs.

How was this change implemented?

vim

How did you validate the change?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow

See also: apache/kvrocks#664

Could also do something like https://gist.github.com/ericphanson/7340da7345e80cb037ce4bad5f3f70e0, but that introduces another dependency.

Release notes

Documentation Changes

@morancj
Copy link
Member Author

morancj commented May 30, 2023

I've not done this for the scheduled cron Actions.

@morancj morancj requested a review from enekofb May 30, 2023 10:54
@morancj
Copy link
Member Author

morancj commented May 30, 2023

Happy to try this out somewhere else first, if desired. 😄

@morancj morancj marked this pull request as ready for review May 30, 2023 14:04
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you get a chance to test it with any of the workflows? if so, feel free to share it to verify that works as expected.

@lasomethingsomething
Copy link
Contributor

@morancj still working on this?

@lasomethingsomething
Copy link
Contributor

Closing due to lack of activity and response.

@enekofb enekofb self-assigned this Nov 7, 2023
@enekofb
Copy link
Contributor

enekofb commented Nov 7, 2023

assigning to me to test it out!

@enekofb enekofb reopened this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants