This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Fix yaml parsing for list obj #100

Merged

bboreham merged 1 commit into weaveworks:master from CtheSky:fix_list_obj_parsing

Jun 24, 2020

Contributor

CtheSky commented Mar 16, 2020

A quick fix for #96, as documented here:

The name of a list kind must end with "List". Lists have a limited set of common metadata. All lists use the required "items" field to contain the array of objects they return. Any kind that has the "items" field must be a list kind.

Equality test is not enough here, types like RoleBindingList and RoleList will fail.


          Fix yaml parsing for list obj

b6e6650

Contributor

bboreham commented Jun 23, 2020

Thanks for the PR. It looks ok.
Now I have to figure out why CI didn't run.

bboreham merged commit 078209e into weaveworks:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet